Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing support to pass cloud-provider via userData to Bottlerocket nodes #4118

Closed
mrpentrexyl opened this issue Jun 23, 2023 · 0 comments · Fixed by #4121
Closed

Missing support to pass cloud-provider via userData to Bottlerocket nodes #4118

mrpentrexyl opened this issue Jun 23, 2023 · 0 comments · Fixed by #4121
Labels
feature New feature or request

Comments

@mrpentrexyl
Copy link

Description

Observed Behavior:

Not possible to pass cloud-provider to settings.kubernetes via userData, because it is not listed in
https://github.com/aws/karpenter/blob/main/pkg/providers/amifamily/bootstrap/bottlerocketsettings.go#L45

Why this is needed ?
Bottlerocket nodes tend to intermittently stuck in boot due to bottlerocket-os/bottlerocket#3214

Suggested workaround is to inject cloud-provider = "aws" to settings.kubernetes via userData.

Expected Behavior:

being able to inject to bottlerocket nodes cloud-provider = "aws"

Reproduction Steps (Please include YAML):

apiVersion: karpenter.k8s.aws/v1alpha1
kind: AWSNodeTemplate
metadata:
  name: {{ $type }}
spec:
  amiFamily: Bottlerocket
  tags:
    aws-node-termination-handler/managed/{{ $clusterName }}: "true"
  subnetSelector:
    karpenter.sh/discovery: {{ $clusterName }}
  securityGroupSelector:
    karpenter.sh/discovery: {{ $clusterName }}
  userData:  |
    [settings.kubernetes]  
    cloud-provider = "aws" <------- This is what is important to inject else bottlerocket instances intermittently get stuck in booting.
  blockDeviceMappings:
    - deviceName: /dev/xvda
      ebs:
        volumeType: gp3
        volumeSize: 2Gi
        iops: 3000
        throughput: 125
        deleteOnTermination: true
    - deviceName: /dev/xvdb
      ebs:
        volumeType: gp3
        volumeSize: {{ $volumeSize }}
        iops: 3000
        throughput: 125
        deleteOnTermination: true

Versions:

  • Chart Version:
  • Kubernetes Version (kubectl version):
@mrpentrexyl mrpentrexyl added the bug Something isn't working label Jun 23, 2023
@mrpentrexyl mrpentrexyl changed the title Missing support to pass Missing support to pass cloud-provider via userData to Bottlerocket nodes Jun 23, 2023
@ellistarn ellistarn added feature New feature or request and removed bug Something isn't working labels Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants