Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't overwrite existing devcontainer.json and Dockerfile #31

Open
vishalovercome opened this issue May 16, 2023 · 1 comment · May be fixed by #34
Open

Don't overwrite existing devcontainer.json and Dockerfile #31

vishalovercome opened this issue May 16, 2023 · 1 comment · May be fixed by #34
Labels
enhancement New feature or request

Comments

@vishalovercome
Copy link

vishalovercome commented May 16, 2023 •
edited
Loading

With devcontainer now supporting multiple devcontainer.json files within a repo, this extension should probably prompt user for the name of the folder in which the devcontainer.json file ought to be created.

Current implementation simply overwrites a project's existing devcontainer.json as well as Dockerfile files leading to loss of work
@vishalovercome vishalovercome changed the title Don't overwrite existing devcontainer.json Don't overwrite existing devcontainer.json and Dockerfile May 16, 2023
@dacort
Copy link
Contributor

dacort commented May 16, 2023

Definitely a good point!

@dacort dacort added the enhancement New feature or request label May 16, 2023
dacort added a commit that referenced this issue May 16, 2023
@dacort
Make use of multiple devcontainer paths - fixes #31
61a2688
@dacort dacort linked a pull request May 16, 2023 that will close this issue
Update how container images are built #34
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update how container images are built awslabs/amazon-emr-vscode-toolkit
2 participants
@dacort @vishalovercome