Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not compatible with aws-java-sdk-bundle #36

Open
Nick-Anderssohn opened this issue Jun 10, 2019 · 1 comment
Open

Not compatible with aws-java-sdk-bundle #36

Nick-Anderssohn opened this issue Jun 10, 2019 · 1 comment

Comments

@Nick-Anderssohn
Copy link

aws-java-sdk-bundle is one of the modules in the AWS SDK repository. Its purpose is to shade all of the SDK's third-party dependencies such as Jackson or org.apache.commons.logging.

In the AmazonSQSExtendedClient class there is a method getTextFromS3(). Within that method, there is a call to IOUtils.closeQuietly(is, LOG);. LOG is of type org.apache.commons.logging.Log. The problem is, if you use the shaded version of the SDK, then IOUtils.closeQuietly is expecting com.amazonaws.thirdparty.apache.logging.Log instead, which causes it to throw a java.lang.NoSuchMethodError.

I believe this problem could be solved by converting this library into multiple modules and offer a shading module with the exact same rules as aws-java-sdk-bundle.

@ebuildy
Copy link

ebuildy commented Jul 4, 2022

I dont understand this purpose, adding AWS support for Spark is broken:

https://mvnrepository.com/artifact/org.apache.hadoop/hadoop-aws/3.3.1 is adding AWS SDK bundle, so AWS SDK S3 will not work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants