Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve GET request annotation #195

Open
1 task done
ahmarsuhail opened this issue Dec 11, 2024 · 0 comments
Open
1 task done

Improve GET request annotation #195

ahmarsuhail opened this issue Dec 11, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers parquet physical IO

Comments

@ahmarsuhail
Copy link
Contributor

Tell us more about this new feature.

We currently annotate S3 GET requests as "Async" or "Sync" and pass this into the referrer header. This is useful when looking at access logs and performing regression analysis.

This annotation can be improved/fixed to make this analysis easier:

1/ All sequential prefetch requests are currently marked as SYNC, even though these are ASYNC.
2/ All parquet column prefetch requests are marked as ASYNC, we can make this more granular by adding more read modes:
COLUMN_PREFETCH,
FOOTER_PREFETCH,
REMAINDER_COLUMN_PREFETCH

This will allow us to quickly identify where an S3 request came from.

Code of Conduct

  • I agree to follow this project's Code of Conduct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers parquet physical IO
Projects
None yet
Development

No branches or pull requests

1 participant