New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question: when git clone depth override is empty #132

Open

YoonjiJang opened this issue Jul 26, 2022 · 0 comments

YoonjiJang commented Jul 26, 2022

aws-codebuild-jenkins-plugin/src/main/java/CodeBuilder.java

Lines 825 to 832 in 3fbfde2

    
           private Integer generateStartBuildGitCloneDepthOverride() { 
        
               String depth = getParameterized(gitCloneDepthOverride); 
        
               if(depth.isEmpty() || depth.equals("Full")) { 
        
                   return 0; 
        
               } 
        
               return Integer.parseInt(depth); 
        
           }

Why is the plugin using 0 as override when the input value is empty? Doesn't it make more sense to use the pipeline default setting?

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment