Organize imports (#899)

Group imports by crate.
Add instructions to the PR template about clippy and fmt.
Remove PR comments because they don't work on forks.

Signed-off-by: David Calavera <[email protected]>

Author: calavera

.github/PULL_REQUEST_TEMPLATE.md

@@ -1,8 +1,10 @@
-*Issue #, if available:*
+📬 *Issue #, if available:*
 
-*Description of changes:*
+✍️ *Description of changes:*
 
-By submitting this pull request
+🔏 *By submitting this pull request*
 
-- [ ] I confirm that my contribution is made under the terms of the Apache 2.0 license.
+- [ ] I confirm that I've ran `cargo +nightly fmt`.
+- [ ] I confirm that I've ran `cargo clippy --fix`.
 - [ ] I confirm that I've made a best effort attempt to update all relevant documentation.
+- [ ] I confirm that my contribution is made under the terms of the Apache 2.0 license.

.github/workflows/format.yml

@@ -3,53 +3,29 @@ name: Formatting and Linting
 on: [push, pull_request]
 
 jobs:
-  check:
+  fmt:
+    name: Cargo fmt
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3
-      - uses: dtolnay/rust-toolchain@stable
+      - uses: dtolnay/rust-toolchain@nightly
+        with:
+          components: rustfmt
       - uses: Swatinem/rust-cache@v2
-
       - name: Run fmt check
         id: cargoFmt
         shell: bash
-        run: cargo fmt --all -- --check
-      - name: Notify fmt check
-        if: failure() && steps.cargoFmt.outcome == 'failure'
-        uses: actions/github-script@v6
-        with:
-          script: |
-            const message = `👋 It looks like your code is not formatted like we expect.
-              
-              Please run \`cargo fmt\` and push the code again.`;
-      
-            await github.rest.issues.createComment({
-              issue_number: context.issue.number,
-              owner: context.repo.owner,
-              repo: context.repo.repo,
-              body: message,
-            });
-            core.setFailed('It looks like there are formatting errors');
-      
+        run: cargo +nightly fmt --all -- --check
+  clippy:
+    name: Cargo clippy
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+      - uses: dtolnay/rust-toolchain@stable
+      - uses: Swatinem/rust-cache@v2
       - name: Run clippy check
         id: cargoClippy
         shell: bash
         run: cargo clippy --workspace --all-features -- -D warnings
-      - name: Notify fmt check
-        if: failure() && steps.cargoClippy.outcome == 'failure'
-        uses: actions/github-script@v6
-        with:
-          script: |
-            const message = `👋 It looks like your code has some linting issues.
-              
-              Please run \`cargo clippy --fix\` and push the code again.`;
-      
-            await github.rest.issues.createComment({
-              issue_number: context.issue.number,
-              owner: context.repo.owner,
-              repo: context.repo.repo,
-              body: message,
-            });
-            core.setFailed('It looks like there are linting errors');
 
 

.rustfmt.toml

@@ -1,6 +1,14 @@
 edition = "2021"
-# imports_granularity is unstable
-# # https://github.com/rust-lang/rustfmt/blob/master/Configurations.md#merge_imports
-# imports_granularity = "Crate"
+
 # https://github.com/rust-lang/rustfmt/blob/master/Configurations.md#max_width
 max_width = 120
+
+#https://github.com/rust-lang/rustfmt/blob/master/Configurations.md#reorder_imports
+reorder_imports = true
+
+#https://github.com/rust-lang/rustfmt/blob/master/Configurations.md#unstable_features
+unstable_features = true
+
+# imports_granularity is unstable
+# https://github.com/rust-lang/rustfmt/blob/master/Configurations.md#merge_imports
+imports_granularity = "Crate"

lambda-events/src/custom_serde/codebuild_time.rs

@@ -1,7 +1,7 @@
 use chrono::{DateTime, NaiveDateTime, Utc};
-use serde::ser::Serializer;
 use serde::{
     de::{Deserializer, Error as DeError, Visitor},
+    ser::Serializer,
     Deserialize,
 };
 use std::fmt;

lambda-events/src/custom_serde/float_unix_epoch.rs

@@ -1,8 +1,7 @@
 use serde::{de, ser};
 use std::fmt;
 
-use chrono::offset::TimeZone;
-use chrono::{DateTime, LocalResult, Utc};
+use chrono::{offset::TimeZone, DateTime, LocalResult, Utc};
 
 enum SerdeError<V: fmt::Display, D: fmt::Display> {
     NonExistent { timestamp: V },

lambda-events/src/custom_serde/headers.rs

@@ -1,7 +1,8 @@
-use http::header::HeaderName;
-use http::{HeaderMap, HeaderValue};
-use serde::de::{self, Deserializer, Error as DeError, MapAccess, Unexpected, Visitor};
-use serde::ser::{Error as SerError, SerializeMap, Serializer};
+use http::{header::HeaderName, HeaderMap, HeaderValue};
+use serde::{
+    de::{self, Deserializer, Error as DeError, MapAccess, Unexpected, Visitor},
+    ser::{Error as SerError, SerializeMap, Serializer},
+};
 use std::{borrow::Cow, fmt};
 
 /// Serialize a http::HeaderMap into a serde str => Vec<str> map

lambda-events/src/custom_serde/http_method.rs

@@ -1,6 +1,8 @@
 use http::Method;
-use serde::de::{Deserialize, Deserializer, Error as DeError, Unexpected, Visitor};
-use serde::ser::Serializer;
+use serde::{
+    de::{Deserialize, Deserializer, Error as DeError, Unexpected, Visitor},
+    ser::Serializer,
+};
 use std::fmt;
 
 pub fn serialize<S: Serializer>(method: &Method, ser: S) -> Result<S::Ok, S::Error> {

lambda-events/src/custom_serde/mod.rs

@@ -1,6 +1,8 @@
 use base64::Engine;
-use serde::de::{Deserialize, Deserializer, Error as DeError};
-use serde::ser::Serializer;
+use serde::{
+    de::{Deserialize, Deserializer, Error as DeError},
+    ser::Serializer,
+};
 use std::collections::HashMap;
 
 #[cfg(feature = "codebuild")]

lambda-events/src/encodings/http.rs

@@ -1,8 +1,10 @@
 use base64::display::Base64Display;
 use bytes::Bytes;
 use http_body::{Body as HttpBody, SizeHint};
-use serde::de::{Deserialize, Deserializer, Error as DeError, Visitor};
-use serde::ser::{Error as SerError, Serialize, Serializer};
+use serde::{
+    de::{Deserialize, Deserializer, Error as DeError, Visitor},
+    ser::{Error as SerError, Serialize, Serializer},
+};
 use std::{borrow::Cow, mem::take, ops::Deref, pin::Pin, task::Poll};
 
 /// Representation of http request and response bodies as supported

lambda-events/src/encodings/mod.rs

@@ -1,5 +1,5 @@
 use serde::{Deserialize, Serialize};
-use std::{ops::Deref, ops::DerefMut};
+use std::ops::{Deref, DerefMut};
 
 #[cfg(feature = "chrono")]
 mod time;