From 86087eb4a9f50053368ec39d86043443705dfa4b Mon Sep 17 00:00:00 2001
From: Cyril Fait <cfait@misdre.info>
Date: Wed, 15 Nov 2023 18:17:28 +0100
Subject: [PATCH] add cfn_nag in github static checking workflow

also regroup black and ruff under a single python job
---
 .github/workflows/static-checking.yml | 35 +++++++++++++++------------
 1 file changed, 19 insertions(+), 16 deletions(-)

diff --git a/.github/workflows/static-checking.yml b/.github/workflows/static-checking.yml
index 532e489f..361a116f 100644
--- a/.github/workflows/static-checking.yml
+++ b/.github/workflows/static-checking.yml
@@ -9,7 +9,7 @@ permissions:
   contents: read
 
 jobs:
-  cfnlint:
+  cfn:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3
@@ -17,15 +17,30 @@ jobs:
         uses: actions/setup-python@v4
         with:
           python-version: 3.11
+      - name: Set up Ruby 3.2
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: 3.2
       - name: install requirements
         run: |
           python -m pip install --upgrade pip
           python -m pip install cfn-lint
+          gem install cfn-nag
       - name: cfn-lint
         run: |
           find . -not \( -path ./sdlf-utils -prune \) -type f -name '*.yaml' -print0 \
           | xargs -0 cfn-lint
-  black:
+      - name: cfn-nag
+        run: |
+          cat <<EOT >> .cfn-nag-deny-list.yml
+          - id: W61
+            reason: |-
+              Certificates are handled by customers downstream, see https://docs.aws.amazon.com/emr/latest/ManagementGuide/emr-encryption-enable.html#emr-encryption-certificates
+              This is ignored only during CI as we want customers to be aware they need to update the security configuration should they choose to use it.
+          EOT
+          find . -not \( -path ./sdlf-utils -prune \) -type f -name '*.yaml' -print0 \
+          | xargs -0 -L 1 cfn_nag_scan --fail-on-warnings --ignore-fatal --deny-list-path .cfn-nag-deny-list.yml --input-path
+  python:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3
@@ -36,21 +51,9 @@ jobs:
       - name: install requirements
         run: |
           python -m pip install --upgrade pip
-          python -m pip install black
+          python -m pip install black ruff
       - name: black
         run: black --check .
-  ruff:
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v3
-      - name: Set up Python 3.11
-        uses: actions/setup-python@v4
-        with:
-          python-version: 3.11
-      - name: install requirements
-        run: |
-          python -m pip install --upgrade pip
-          python -m pip install ruff
       - name: ruff
         run: ruff check .
   shellcheck:
@@ -64,4 +67,4 @@ jobs:
       - name: shellcheck
         run: |
           find . -not \( -path ./sdlf-utils -prune \) -type f \( -name '*.sh' -o -name '*.bash' -o -name '*.ksh' \) -print0 \
-          | xargs -0 shellcheck -x --format gcc
\ No newline at end of file
+          | xargs -0 shellcheck -x --format gcc