You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+8-3Lines changed: 8 additions & 3 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -149,20 +149,25 @@ BREAKING CHANGE: Description of what broke and how to achieve this behavior now
149
149
150
150
### Step 5: Pull Request
151
151
152
-
* Push to a GitHub fork or to a branch (naming convention: `<user>/<feature-bug-name>`)
152
+
* Push to a GitHub fork
153
153
* Submit a Pull Requests on GitHub.
154
-
* Please follow the PR checklist written below. We trust our contributors to self-check, and this helps that process!
154
+
* Please follow the PR checklist written above. We trust our contributors to self-check, and this helps that process!
155
155
* Discuss review comments and iterate until you get at least one “Approve”. When iterating, push new commits to the
156
156
same branch. Usually all these are going to be squashed when you merge to master. The commit messages should be hints
157
157
for you when you finalize your merge commit message.
158
158
* Make sure to update the PR title/description if things change. The PR title/description are going to be used as the
159
159
commit title/message and will appear in the CHANGELOG, so maintain them all the way throughout the process.
160
+
* Make sure your PR builds successfully (we have CodeBuild setup to automatically build all PRs)
160
161
162
+
#### CodeBuild Build steps
161
163
164
+
The CodeBuild runs through the following build steps:
165
+
* Content scanning using Viperlight utility. It is a security, vulnerability and general risk highlighting tool. The source code for utility is located [here](https://s3.amazonaws.com/viperlight-scanner/latest/viperlight.zip) It uses [.viperlightignore](https://github.com/awslabs/aws-solutions-constructs/blob/master/.viperlightignore) to override any false alarms.
166
+
* Build/validate/package all the constructs in the library
167
+
* Scan the Cloudformation templates generated by [Integration Tests](https://github.com/awslabs/aws-solutions-constructs/blob/master/CONTRIBUTING.md#integration-tests) using (cfn_nag)[https://github.com/stelligent/cfn_nag]
162
168
163
169
### Step 6: Merge
164
170
165
-
* Make sure your PR builds successfully (we have CodeBuild setup to automatically build all PRs)
166
171
* Once approved and tested, a maintainer will squash-merge to master and will use your PR title/description as the
Copy file name to clipboardExpand all lines: source/patterns/@aws-solutions-constructs/aws-apigateway-dynamodb/test/__snapshots__/apigateway-dynamodb.test.js.snap
0 commit comments