Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix snapshot bot #192

Merged
merged 2 commits into from
Nov 7, 2023
Merged

Conversation

StoneDot
Copy link
Contributor

@StoneDot StoneDot commented Nov 6, 2023

Issue #, if available:
Currently, the snapshot bot does not work correctly.
https://github.com/awslabs/dynein/actions/runs/6730473189.

Description of changes:
This pull request will fix the failure to generate a snapshot. Due to permission restriction, the bot only generates a diff. It means that the application of patches becomes the duty of requesters of pull requests.

The following is the example behavior of the bot.
StoneDot#17 (comment)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@wafuwafu13 wafuwafu13 self-requested a review November 6, 2023 21:44
@wafuwafu13
Copy link
Contributor

https://github.com/awslabs/dynein/#bot should be updated

If you want to update snapshots of commands, you can use bot command /snapshot in your pull request. Please note that you must type exactly as written.

bot can't update file now

@wafuwafu13
Copy link
Contributor

I'm trying to figure out why we need this bot

Copy link
Contributor

@wafuwafu13 wafuwafu13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we leave this bot, we have to change the README.md description

@StoneDot
Copy link
Contributor Author

StoneDot commented Nov 7, 2023

The bot was introduced because some contributors may not have a Windows environment or a Linux environment. I believe this feature is still helpful for those who do not have an environment to create a snapshot. Manually changing the snapshot is error-prone and dull work. Generated the diff file mitigates this pain.

@StoneDot
Copy link
Contributor Author

StoneDot commented Nov 7, 2023

I have updated the documents and described the needs of the bot. Could you please check it again?

Copy link
Contributor

@wafuwafu13 wafuwafu13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wafuwafu13 wafuwafu13 merged commit 5411a7a into awslabs:main Nov 7, 2023
2 checks passed
@StoneDot StoneDot deleted the fix-snapshot-bot branch November 7, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants