-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix snapshot bot #192
Conversation
https://github.com/awslabs/dynein/#bot should be updated
bot can't update file now |
I'm trying to figure out why we need this bot
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we leave this bot, we have to change the README.md description
The bot was introduced because some contributors may not have a Windows environment or a Linux environment. I believe this feature is still helpful for those who do not have an environment to create a snapshot. Manually changing the snapshot is error-prone and dull work. Generated the diff file mitigates this pain. |
I have updated the documents and described the needs of the bot. Could you please check it again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Issue #, if available:
Currently, the snapshot bot does not work correctly.
https://github.com/awslabs/dynein/actions/runs/6730473189.
Description of changes:
This pull request will fix the failure to generate a snapshot. Due to permission restriction, the bot only generates a diff. It means that the application of patches becomes the duty of requesters of pull requests.
The following is the example behavior of the bot.
StoneDot#17 (comment)
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.