Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary vec! from create_temporary_table_with_items invocations #238

Open
StoneDot opened this issue May 17, 2024 · 0 comments
Open
Assignees
Labels
good first issue Good for newcomers test Something related to test

Comments

@StoneDot
Copy link
Contributor

Currently we typically use create_temporary_table_with_items with vec!. However, current implementation does not need to use vec! because of the improvement of #218. We can simplify the implementation of caller sides.

    pub async fn create_temporary_table_with_items<ItemIter>(
        &mut self,
        pk: &'static str,
        sk: Option<&'static str>,
        items: ItemIter,
    ) -> Result<String, Box<dyn std::error::Error>>
    where
        ItemIter: IntoIterator<Item = TemporaryItem>,
@StoneDot StoneDot added good first issue Good for newcomers test Something related to test labels May 17, 2024
@kzym-w kzym-w self-assigned this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers test Something related to test
Projects
None yet
Development

No branches or pull requests

2 participants