Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multisig-prover and router migrations #596

Merged

Conversation

eguajardo
Copy link
Contributor

Description

https://axelarnetwork.atlassian.net/browse/AXE-4689

Todos

  • Unit tests
  • Manual tests
  • Documentation
  • Connect epics/issues

Steps to Test

Expected Behaviour

Other Notes

@eguajardo eguajardo requested a review from a team as a code owner August 21, 2024 22:53
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 97.82609% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (patch/v1.0.0-migrations-fix/router-prover@bb58d24). Learn more about missing BASE report.

Files Patch % Lines
contracts/multisig-prover/src/contract.rs 0.00% 2 Missing ⚠️
contracts/router/src/contract.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                             Coverage Diff                              @@
##             patch/v1.0.0-migrations-fix/router-prover     #596   +/-   ##
============================================================================
  Coverage                                             ?   93.94%           
============================================================================
  Files                                                ?      190           
  Lines                                                ?    26827           
  Branches                                             ?        0           
============================================================================
  Hits                                                 ?    25202           
  Misses                                               ?     1625           
  Partials                                             ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eguajardo eguajardo changed the base branch from release/v1.0.x to patch/v1.0.0-migrations-fix/router-prover August 22, 2024 16:19
@eguajardo eguajardo merged commit 46cb844 into patch/v1.0.0-migrations-fix/router-prover Aug 22, 2024
8 checks passed
@eguajardo eguajardo deleted the fix/v1_0_0_migrations branch August 22, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants