chore(sui): use common utils instead of evm utils #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npty
force-pushed
the
chore/use-common-utils
branch
from
c29a4fd to
295de53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AXE-4552
This PR replaces all
../evm/utilswith../common/utilswhich was recently introduced in this PR and adds two new functions which arevalidateParametersandisKeccak256Hashsince we have also utilized it in thesui/deploy-contract.js.One additional change is to fix a minor bug where we didn't return
objectIdout ofgetObjectIdsByObjectTypes.Note that
validateParametersincommon/utils.jsdiffers fromevm/utils.js. The evm one will also supported evm-related validation methods such asisContract,isValidPrivateKey,isValidTokenId,isValidTokenId,isValidCalldata, etc where the common one doesn't include those functions.