GButton protected members

[paulocoutinhox]

Hi,

Can we turn two protected members as public?

axmol/extensions/fairygui/src/fairygui/GButton.h

Lines 67 to 68 in 6304c88

	void setState(const std::string& value);
	void setCurrentState();

I can't change control state manually using gamepad controller without access it.

This line is making the setSelected unusable, since it start in COMMON state when initialize.

void GButton::setSelected(bool value)
{
    if (_mode == ButtonMode::COMMON)
        return;

Ref:

axmol/extensions/fairygui/src/fairygui/GButton.cpp

Lines 103 to 106 in 6304c88

	void GButton::setSelected(bool value)
	{
	if (_mode == ButtonMode::COMMON)
	return;

The common mode is the default button behavior, but i can't simulate hover/selected effect without have access to update it state:

Thanks.

[paulocoutinhox]

My temporary workaround:

#include "gui/MenuWindowGUI.h"

namespace game::gui {

USING_NS_FGUI;

class GButton2 : public GButton {
public:
    void xyz() {
        setState(GButton::SELECTED_OVER);
    }
};

void MenuWindowGUI::onInit() {
    setContentPane(UIPackage::createObject("Main", "GameMenuWindow")->as<GComponent>());
    center();

    getContentPane()->getChildByPath("btStart")->addClickListener(CC_CALLBACK_1(MenuWindowGUI::onBtStartClick, this));
}

void MenuWindowGUI::onShown() {
    auto button =static_cast<GButton2 *>(getContentPane()->getChildByPath("btStart"));
    button->xyz();
}

void MenuWindowGUI::onBtStartClick(fairygui::EventContext *context) {
    btStartClickCallback(context);
}

} // namespace game::gui

[smilediver]

I don't think modifying 3rd party lib or its API is a good idea.

What type of button are you implementing? A simple clickable button or a checkbox like thing? As I understand, the hover is done using GButton::onRollOver() and GButton::onRollOut(). GButton::setSelected() is used for checkboxes, not buttons.

[paulocoutinhox]

What you use to change the state manually?

[smilediver]

We don't use FairyGUI, I just read the code and docs.

[paulocoutinhox]

What you use for games UI creation?

[smilediver]

We use our custom UI systems.