Added support for nesting formats in LocalizationFormatter (#350)

* Added support for nested formats in LocalizationFormatter (without double parsing)


---------

Co-authored-by: Sitko, Michał <[email protected]>

Author: zacateras

src/SmartFormat.Tests/Extensions/LocalizationFormatterTests.cs

@@ -204,4 +204,17 @@ public void Combine_With_PluralLocalizationFormatter(string format, int count, s
         var actual = smart.Format(CultureInfo.GetCultureInfo(cultureName), format, count);
         Assert.That(actual, Is.EqualTo(expected));
     }
-}
+
+    [TestCase("{:L:{ProductType}}", "en", "paper", "Paper")]
+    [TestCase("{:L:{ProductType}}", "de", "paper", "das Papier")]
+    [TestCase("{:L:{ProductType}}", "fr", "paper", "Papier")]
+    [TestCase("{:L:{ProductType}}", "en", "pen", "Pen")]
+    [TestCase("{:L:{ProductType}}", "de", "pen", "der Kugelschreiber")]
+    [TestCase("{:L:{ProductType}}", "fr", "pen", "Bic")]
+    public void Combine_With_Nesting(string format, string cultureName, string productType, string expected)
+    {
+        var smart = GetFormatterWithRegisteredResource();
+        var actual = smart.Format(CultureInfo.GetCultureInfo(cultureName), format, new { ProductType = productType });
+        Assert.That(actual, Is.EqualTo(expected));
+    }
+}

src/SmartFormat.Tests/Localization/LocTest1.de.resx

@@ -132,4 +132,10 @@
   <data name="{} items" xml:space="preserve">
     <value>{} Elemente</value>
   </data>
+  <data name="paper" xml:space="preserve">
+    <value>das Papier</value>
+  </data>
+  <data name="pen" xml:space="preserve">
+    <value>der Kugelschreiber</value>
+  </data>
 </root>

src/SmartFormat.Tests/Localization/LocTest1.es.resx

@@ -132,4 +132,10 @@
   <data name="{} items" xml:space="preserve">
     <value>{} elementos</value>
   </data>
+  <data name="paper" xml:space="preserve">
+    <value>Papel</value>
+  </data>
+  <data name="pen" xml:space="preserve">
+    <value>Bolígrafo</value>
+  </data>
 </root>

src/SmartFormat.Tests/Localization/LocTest1.fr.resx

@@ -132,4 +132,10 @@
   <data name="{} items" xml:space="preserve">
     <value>{} éléments</value>
   </data>
+  <data name="paper" xml:space="preserve">
+    <value>Papier</value>
+  </data>
+  <data name="pen" xml:space="preserve">
+    <value>Bic</value>
+  </data>
 </root>

src/SmartFormat.Tests/Localization/LocTest1.resx

@@ -136,4 +136,10 @@
   <data name="{} items" xml:space="preserve">
     <value>{} items</value>
   </data>
+  <data name="paper" xml:space="preserve">
+    <value>Paper</value>
+  </data>
+  <data name="pen" xml:space="preserve">
+    <value>Pen</value>
+  </data>
 </root>

src/SmartFormat/Extensions/LocalizationFormatter.cs

@@ -6,7 +6,9 @@
 using System.Collections.Generic;
 using System.Globalization;
 using SmartFormat.Core.Extensions;
+using SmartFormat.Core.Output;
 using SmartFormat.Core.Parsing;
+using SmartFormat.Pooling.SmartPools;
 using SmartFormat.Utilities;
 
 namespace SmartFormat.Extensions;
@@ -68,6 +70,21 @@ public bool TryEvaluateFormat(IFormattingInfo formattingInfo)
         // Get the localized string
         var localized = LocalizationProvider!.GetString(formattingInfo.Format!.RawText, cultureInfo);
 
+        // Try formatting if localized string was not found, but a format has nested items
+        if (localized is null && formattingInfo.Format!.HasNested)
+        {
+            using var zsOutput = new ZStringOutput(ZStringBuilderExtensions.CalcCapacity(formattingInfo.Format));
+
+            var localizableFormatDetails = FormatDetailsPool.Instance.Get().Initialize(_formatter!,
+                formattingInfo.Format, InitializationObject.ObjectList, null, zsOutput);
+            var localizableFormattingInfo = FormattingInfoPool.Instance.Get().Initialize(localizableFormatDetails,
+                formattingInfo.Format, formattingInfo.CurrentValue);
+
+            _formatter!.Format(localizableFormattingInfo);
+
+            localized = LocalizationProvider!.GetString(zsOutput.ToString(), cultureInfo);
+        }
+
         if (localized is null) throw new LocalizationFormattingException(formattingInfo.Format, $"No localized string found for '{formattingInfo.Format!.RawText}'", formattingInfo.Format.StartIndex);
 
         // Use an existing Format from the cache