Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of absolute paths causes failures with subpath-based reverse proxying #194

Open
gongloo opened this issue Jun 18, 2024 · 0 comments
Open

Comments

@gongloo
Copy link
Contributor

gongloo commented Jun 18, 2024

It'd be great to see relative paths used throughout the JS code.

In use cases involving reverse proxies, it's common to host multiple devices behind a single HTTP proxy using subpath-based routing of requests. In my case, I've got a thermostat device accessible at http://hostname/thermostat. I can of course hit http://hostname/thermostat/update, but the OTA start requests fail right off the bat because they use absolute /ota paths.

Should be a relatively straightforward fix in the JS. Happy to submit a PR given the JS source you'd like to see modified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant