Core/Pets: summon animation on loading warlock pet

[sogladev]

Current Behaviour

Upon dismount or loading a warlock pet, the summon spell is being fake casted. This results in a visual/animation/sound that is not blizzlike

pet_summon.mp4

Expected Blizzlike Behaviour

No summon animation on loading pet

Source

I believe this was cherry-picked from TC in TrinityCore/TrinityCore@30d0b2e

This fix send a fake-cast if pet is created by a spell. This fixes raise dead, however most spells do not have a cooldown and do not need this fake-cast fix to be send

original wrath pvp warlock footage showing lack of dismount animation
https://www.youtube.com/watch?v=hD5xBPkxd2c
https://www.youtube.com/watch?v=qeY6_mNVZSQ

Steps to reproduce the problem

.cheat cast
.learn 697 summon voidwalker
.add 6265 32 add soul shards
.learn 46584 raise dead
.learn 23228 learn a mount

make a death knight with master of ghouls talent so make ghoul a pet

1. summon voidwalker
2. mount
3. dismount, observe summon animation

Extra Notes

master...sogladev:azerothcore-wotlk:fix(Core/Pet)LoadPetFromDB

potential fix: add if (petInfo->CreatedBySpellId && spellInfo && spellInfo->CategoryRecoveryTime > 0)

could also check for spellInfo->RecoveryTime but these 2 seem to be 0 for most summon spells besides raise dead

azerothcore-wotlk/src/server/game/Entities/Pet/Pet.cpp

Line 397 in b055faf

if (petInfo->CreatedBySpellId)

AC rev. hash/commit

b055faf

Operating system

Ubuntu 24.04

Custom changes or Modules

No response