Skip to content
This repository has been archived by the owner on Aug 18, 2022. It is now read-only.

Refactor Azure CLI calls to API calls #97

Open
benc-uk opened this issue Jun 16, 2021 · 2 comments
Open

Refactor Azure CLI calls to API calls #97

benc-uk opened this issue Jun 16, 2021 · 2 comments
Labels
easy 😁 rover-go Reimplement rover in Go

Comments

@benc-uk
Copy link
Collaborator

benc-uk commented Jun 16, 2021

The function GetVMIdentities() in azure/cli.go needs rewriting to call the Azure API rather than use the CLI

Reasons

  • Eventually we many be able to remove dependence on Azure CLI entirely

Notes / Considerations

None

Outcomes

  • New function getVM(vmName string, resGroup string) in vm.go to call the API and get the VM details,
  • GetVMIdentities calls this new function
@benc-uk benc-uk added easy 😁 rover-go Reimplement rover in Go labels Jun 16, 2021
@sebastus
Copy link
Collaborator

There are a number of other functions that rely on az cli, notably those in pkg/testing/cli.go

@benc-uk
Copy link
Collaborator Author

benc-uk commented Jun 21, 2021

I'm less worried about tests, it's runtime dependency I'd like to minimise
The ultimate prize would be to remove any reliance on the Azure CLI, but that would involve handling our own auth, getting tokens etc, which is long way off, but no reason to make things harder for ourselves.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
easy 😁 rover-go Reimplement rover in Go
Projects
None yet
Development

No branches or pull requests

2 participants