Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile could use 'chmod' on programs subdirectory #398

Open
sdowdy opened this issue Apr 29, 2024 · 0 comments
Open

Makefile could use 'chmod' on programs subdirectory #398

sdowdy opened this issue Apr 29, 2024 · 0 comments

Comments

@sdowdy
Copy link

sdowdy commented Apr 29, 2024

Makefile line:
cp -r programs '$(DESTDIR)$(PREFIX)/share/xdg-ninja/'
doesn't account for umask of running user, whereas all the 'install' directives explicitly set the modes.

I use a umask of 077 for 'root', thus the programs are not readable by group/other, requiring a postinstall:

sudo chmod 755 /opt/share/xdg-ninja/programs/
sudo chmod 644 /opt/share/xdg-ninja/programs/*

Thanks,
--stephen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant