[#529] if with falsy literal returns nil

Author: borkdude

CHANGELOG.md

@@ -2,6 +2,12 @@
 
 For a list of breaking changes, check [here](#breaking-changes)
 
+## v0.2.3
+
+### Enhancements / fixes
+
+- if with falsy literal returns nil [#529](https://github.com/borkdude/sci/issues/529)
+
 ## v0.2.2
 
 ### Enhancements / fixes

resources/SCI_VERSION

@@ -1 +1 @@
-0.2.3-SNAPSHOT
+0.2.3

src/sci/impl/analyzer.cljc

@@ -474,7 +474,7 @@
       3 (let [condition (nth children 0)
               then (nth children 1)
               else (nth children 2)]
-          (cond (not condition) nil
+          (cond (not condition) else
                 (constant? condition) then
                 :else (ctx-fn
                        (fn [ctx]

test/sci/core_test.cljc

@@ -50,6 +50,8 @@
   (testing "if and when"
     (is (= 1 (eval* 0 '(if (zero? *in*) 1 2))))
     (is (= 2 (eval* 1 '(if (zero? *in*) 1 2))))
+    (is (= 10 (eval* "(if true 10 20)")))
+    (is (= 20 (eval* "(if false 10 20)")))
     (is (thrown-with-msg? #?(:clj Exception :cljs js/Error) #"Too few arguments to if"
                           (eval* '(if))))
     (is (thrown-with-msg? #?(:clj Exception :cljs js/Error) #"Too few arguments to if"