Fix #997: Var is mistaken for local when used under the same name in a let body

Author: borkdude

src/sci/impl/analyzer.cljc

@@ -1234,11 +1234,10 @@
 
 ;;;; Vars
 
-(defn analyze-var [ctx [_ var-name]]
-  (second
-   (resolve/lookup (assoc ctx :bindings {}) var-name false nil true)))
-
-#_(sci.core/eval-string "(def x 2) (let [x 1 x #'x] x)")
+(defn analyze-var [ctx [_ var-name :as expr]]
+  (or (second
+       (resolve/lookup (assoc ctx :bindings {}) var-name false nil true))
+      (throw-error-with-location (str "Unable to resolve var: " var-name) expr)))
 
 (defn analyze-set! [ctx [_ obj v :as expr]]
   (cond

test/sci/core_test.cljc

@@ -342,9 +342,8 @@
      :cljs (is (nil? (sci/eval-string "(resolve 'js/Error)" {:classes {'js #js {:Error js/Error}}}))))
   (is (= 1 (eval* "((binding [*ns* 'user] (resolve 'inc)) 0)")))
   (is (= 2 (eval* "(def x 2) (let [x 1 x #'x] @x)")))
-  ;; TODO: crash: user=> (sci/eval-string "#'ffoooo")
-  nil
-  )
+  (is (thrown-with-msg? Exception #"dude" (eval* "(defn foo [] #'dude)")))
+  (is (thrown-with-msg? Exception #"inc" (sci/eval-string "(defn foo [] #'inc)" {:deny '[inc]}))))
 
 #?(:clj
    (deftest type-hint-let-test