Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drush rn can't tell the difference between minor & bug-fix releases #129

Open
jenlampton opened this issue Jan 16, 2018 · 2 comments
Open

Comments

@jenlampton
Copy link
Member

jenlampton commented Jan 16, 2018

Maybe I'm not using drush rn correctly, but it seems to generate the same results, regardless of which branch I'm on, or which tag I reference.

When we do a minor version release of backdrop we need to be able to generate release notes for both the bug-fix release, and the minor version, and those two lists should be different.

If anyone has suggestions as to how those commands are supposed to be run, please let me know.

@jenlampton jenlampton changed the title drush rn can't tell the difference between minor or bug-fix versions drush rn can't tell the difference between minor or bug-fix releases Jan 16, 2018
@jenlampton jenlampton changed the title drush rn can't tell the difference between minor or bug-fix releases drush rn can't tell the difference between minor & bug-fix releases Jan 16, 2018
@serundeputy
Copy link
Member

@quicksketch explained that this is because drush rn uses git log under the hood and git log can not give a diff log from releases that are on different branches.

closing as cant' fix.

@jenlampton
Copy link
Member Author

jenlampton commented Jan 15, 2019

But the commit message on both commits is identical, even though the commit hash is different. Drush can loop over all the commits, and if the log message is identical on two commits, it can strip one out. Drush is greater than Git here, so we should make our tools do what git cannot :)

Managing release notes for core releases is a real pain when we do a lot in the bug fix releases (which is good!) because we currently need to go through the whole commit list manually, check each issue on GitHub to see what milestone it's in, and pull out each one that was committed to a bug-fix release.

We need better tooling for this process, and Drush is already half-way there.

Today I tried crazy stuff like this:

git log --pretty=format:'* %s' --since="2018-09-16" 1.x --not 1.11.x > ~/Desktop/notes.md

... to no avail. I'm still doing it all manually :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants