Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bmake] Support non-Backdrop projects #134

Open
ghost opened this issue Jan 22, 2018 · 9 comments
Open

[bmake] Support non-Backdrop projects #134

ghost opened this issue Jan 22, 2018 · 9 comments

Comments

@ghost
Copy link

ghost commented Jan 22, 2018

As per #130 (comment), I'd like to see bmake support non_backdrop projects, such as other GitHub repositories, custom URLs, jQuery libraries, etc.

An example use-case for this would be my personal Backdrop base theme: https://github.com/PackWeb/pw_theme
It's not on backdrop-contrib as it's specific to my needs, but I use it on every Backdrop site I build. So the ability to build a Backdrop site from a make file that included this would be great.

Other use cases might be downloading jQuery libraries, etc.

@ghost
Copy link
Author

ghost commented Jan 26, 2018

Also, when you do this, please allow for both keeping and removing .git directories.

On the one hand, if you download a git repo, you often don't want all the hidden files and everything that comes with it (just download and forget).
On the other hand, sometimes you want to keep the git repo linked upstream so you can pull down changes in future.

Drupal's drush has a --working-copy argument for keeping .git directories (it deletes them otherwise).

@ghost
Copy link
Author

ghost commented Jul 17, 2019

I've started a PR (#187) for this that allows cloning a git repository (e.g. pw_module[git] = [email protected]:PackWeb/pw_module.git), but I'm struggling to get the path working properly. Currently it's cloning the repo into /BACKDROP_ROOT/modules/... (i.e. its not converting BACKDROP_ROOT into the actual root path). Help needed please!

@ghost
Copy link
Author

ghost commented Jul 17, 2019

There are other possibilities to implement after this (e.g. patches, third-party libraries, etc.), but this suits my needs for now, so unless others require additional functionality, I'd say let's try and get this working, release, and then add more functionality as requested.

@serundeputy
Copy link
Member

Merged! thanks @BWPanda this will ship w/ 1.x-1.1.0

@ghost
Copy link
Author

ghost commented Jul 27, 2019

@serundeputy Thanks for this, but were you able to fix the bug with the path: #134 (comment) The PR wasn't ready to be committed yet, at least until that was fixed...

@ghost ghost reopened this Jul 27, 2019
@serundeputy
Copy link
Member

Sorry about that @BWPanda ; no i did not fix the path issue.

I tried to look at it today, but I can't remember how to test bmake in lando 😖

I should have written down the devOps for bmake development 😢

If you have the steps it takes we should dump them into a /commands/make/README.md file in case i forget again (very probable).

@ghost
Copy link
Author

ghost commented Jul 27, 2019

@serundeputy Try this: https://github.com/BWPanda/drush-bmake-testing

If you want to keep it around for future, I'm happy to transfer it over to you, or you can merge it into the Drush repo if appropriate.

@serundeputy
Copy link
Member

thanks; that is essentially the same as what i have: https://github.com/backdrop-contrib/drush/wiki/Contributing-code-to-the-Backdrop-drush-extension. which is working fine, but not for bmake

I thought there was some additional hoop i had to jump through, but i'm drawing a blank, but if it is working for you then maybe i just need to destroy and start anew;

when i come by some time; i'll do that

@ghost
Copy link
Author

ghost commented Jul 30, 2019

@serundeputy I remember trying to start with your dev lando file, but having issues... After playing around and changing things, I ended up with the one I linked to (e.g. the main difference being I still use the packaged version of Drupal Drush, but then the git repo version of Backdrop Drush).

Destroy all the things! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants