Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pretty terminal font colors for drush cset #218

Closed
klonos opened this issue Apr 10, 2020 · 5 comments · Fixed by #219
Closed

Pretty terminal font colors for drush cset #218

klonos opened this issue Apr 10, 2020 · 5 comments · Fixed by #219

Comments

@klonos
Copy link
Member

klonos commented Apr 10, 2020

I have a script that sets up my local when working on Backdrop issues. At the very end of it, I have a series of drush cset commands, and the way they are being output on the terminal (white font on black) makes it hard to distinguish which settings have been set to what values:

Screen Shot 2020-04-10 at 6 51 34 am

I thought that we should either be wrapping those in single/double quotes or any other character, but then noticed the beautiful light cyan on black text produced by lando, and I thought better something like that instead.

@klonos
Copy link
Member Author

klonos commented Apr 10, 2020

...or perhaps we should introduce a drush_colorize_output($output, $color) function to be re-used in other places?

@serundeputy
Copy link
Member

I like it just need some time to pull it down and test it.

@serundeputy
Copy link
Member

@klonos thanks this is great!

I changed the color from 96m to 32m as that is what is used elsewhere in backdrop-drush-extension, which lends itself to the idea of drush_colorize_output being a good one, i'd ask you to open a feature request for that.

@klonos
Copy link
Member Author

klonos commented Apr 11, 2020

Done: #220

@klonos
Copy link
Member Author

klonos commented Apr 11, 2020

Screen Shot 2020-04-11 at 8 33 42 am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants