Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the operations buttons so they're closer to core #1

Open
herbdool opened this issue Nov 29, 2016 · 8 comments · May be fixed by #37
Open

Improve the operations buttons so they're closer to core #1

herbdool opened this issue Nov 29, 2016 · 8 comments · May be fixed by #37

Comments

@herbdool
Copy link
Collaborator

The core buttons are just simple links and seem to be created automatically with field hooks. Field group uses Ajax on buttons to edit on the form and view modes. Need to know if there's a standard or just custom improve the look/layout in this case.

@olafgrabienski
Copy link
Member

Added a screenshot to illustrate the visual difference:

screen-backdrop-manage-fields-fieldgroup

Have no idea regarding the question standard vs. custom though.

@laryn
Copy link
Member

laryn commented Apr 12, 2018

As a part of this it would make sense to term it as "Configure" and "Delete" instead of "Edit" and "Delete" (see backdrop/backdrop-issues#771)

@herbdool
Copy link
Collaborator Author

Easy part is renaming Edit to Configure. We don't think there's an easy way to change the buttons into the drop-down. The button is javascript driven.

@herbdool
Copy link
Collaborator Author

There's a similar issue on the Manage Display side:

Screenshot from 2021-11-28 00-01-04

Where to put that Delete link?

@laryn
Copy link
Member

laryn commented Nov 29, 2021

One potential (perhaps) is to change the operations to the dropdown and then load the configuration options in a modal instead of an AJAX-inline element. (Similar to how the "Configure" drop button works on a block on a "Manage blocks" layout).

herbdool added a commit that referenced this issue Aug 26, 2022
herbdool added a commit that referenced this issue Jan 4, 2023
herbdool added a commit that referenced this issue Jan 4, 2023
herbdool added a commit that referenced this issue Jan 4, 2023
@herbdool herbdool linked a pull request Jan 4, 2023 that will close this issue
@herbdool
Copy link
Collaborator Author

herbdool commented Jan 5, 2023

@jenlampton I created a replacement PR #37 of this since I had moved code around to separate out the API and the old PR wasn't applying cleanly anymore.

Since this PR is basically borrowing your work, I'm happy if you want to take it over to get it over the finish line or if you want to work together on it. I stopped when trying to get a title for the configure form so that someone knew which field group was being edited.

@stpaultim
Copy link
Member

@herbdool just indicated in Zulip that this might be a blocker to getting Field Groups into core.

@herbdool
Copy link
Collaborator Author

herbdool commented Dec 9, 2023

@stpaultim personally I'm ok if it goes in without this, but others disagree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants