Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider moving main management page to admin "User Accounts" menu #14

Open
bugfolder opened this issue Apr 1, 2022 · 1 comment
Open

Comments

@bugfolder
Copy link

bugfolder commented Apr 1, 2022

Currently, the main management page for this module is in the admin Configuration menu, at admin/config/people/ip-blocking/main, along with the settings tab at admin/config/people/ip-blocking/settings.

I agree that the settings page belongs there. However, the "Main" page seems to be a better fit for the "User Accounts" menu, which currently contains "Add user accounts", "Manage user accounts", and (if IP Address Manager is enabled), "IP Addresses". So I suggest moving the main page to admin/people/ip-blocking, titled "IP Blocking" or "Manage IP Blocking".

The rationale being that pages in admin/config are typically things you set once, then never touch again, while day-to-day management pages go in one of the other admin menus, and "User Accounts" feels like the best fit.

And then the settings page could simply be (appropriately) at admin/config/people/ip-blocking.

@findlabnet
Copy link
Member

Sorry for my late reply, these have been very busy months.
I'm not sure if it's right to split the module form into two menu routes.
The same top-level route - admin/config/people - is the base for my other modules, such as "Antiscan" and "Login allowlist".
Perhaps we need to consider some special route for security-related modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants