New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify that variable_get calls should be update_variable_get. #131

Open

laryn opened this issue Oct 10, 2024 · 1 comment

Member

laryn commented Oct 10, 2024

Follow up from #127

There are two things that need fixing, that I didn't want to touch - they need closer inspection:

[snip]

In xmlsitemap_engines/xmlsitemap_engines.install, function xmlsitemap_engines_update_1000() uses variable_get() but should rather use update_variable_get(), I guess.

I'd recommend to make these two a follow-up, as they're only indirectly related to coding standards.

Links to code (for follow-up):

[snip]

https://github.com/backdrop-contrib/xmlsitemap/blob/1.x-1.x/xmlsitemap_engines/xmlsitemap_engines.install#L63

The text was updated successfully, but these errors were encountered:

Member Author

laryn commented Oct 10, 2024

I haven't looked too closely, but I'd also guess we need to add update_variable_del calls for these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment