PHP warning about missing langcode property on $link['language']

[jenlampton]

I don't still have a copy of the error message, but the below fixes it for me:

change

$link['loc'] = xmlsitemap_get_path_alias($link['loc'], $link['language']->langcode);

to

$link['loc'] = xmlsitemap_get_path_alias($link['loc'], $link['language']->language);

[indigoxela]

This looks wrong and probably is. (And all functional tests fail, BTW.)

The global language object has no "language" property - it is langcode.

So the question is, which other code calls this function like that, so the "language" property exists instead of the "langcode" property.

[jenlampton]

That's a good question, and the answer is I have no idea. This error pops up on cron.
It looks like there is no property language on $link['language'].

If you look in the database query above, these are the fields being retrieved:

  $query->fields('x', array(
    'id',
    'type',
    'subtype',
    'loc',
    'lastmod',
    'changefreq',
    'changecount',
    'priority',
    'language',
    'access',
    'status',
  ));

Here it's definitely language and not langcode so at least we know $link['language'] is correct.

But xmlsitemap_language_load() just pulls a language from language_list(), and languages in that core list definitely use $language->langcode and not $language->language ... so yes, I'm pretty sure this should be $link['language']->langcode. So why then, is it causing such problems...

I've switched to using

     $langcode = LANGUAGE_NONE;
      if (isset($link['language']) && property_exists($link['language'], 'langcode')) {
        $langcode = $link['language']->langcode;
      }
      $link['loc'] = xmlsitemap_get_path_alias($link['loc'], $langcode);

I'll throw in some debug code in an else{} to see if I can catch when it's not there.