Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showcase cards too indistinct #760

Open
docwilmot opened this issue Feb 5, 2021 · 16 comments
Open

Showcase cards too indistinct #760

docwilmot opened this issue Feb 5, 2021 · 16 comments

Comments

@docwilmot
Copy link
Contributor

The cards just blur into each other and the background to my eyes.

screenshot-backdropcms-org-showcase-1612544303595

Added a black border and black shadow for dramatic effect; they seem more like cards then:
screenshot-backdropcms-org-showcase-1612544232125

@oadaeh
Copy link

oadaeh commented Feb 6, 2021

How does it look if you just add the shadow, leaving out the border? Are they still indistinct?

@docwilmot
Copy link
Contributor Author

Also better. Also think the part of the card with the description could be differentiated from the screenshot as well.

@indigoxela
Copy link
Contributor

indigoxela commented Dec 31, 2021

Friendly reminder: that page is broken for several months now:

https://backdropcms.org/showcase

A suggestion for getting the two-column style back:

.view-showcase .view-content {
  display: grid;
  grid-template-columns: repeat(auto-fill, minmax(360px, 1fr));
  gap: 3rem;
}

Not really pretty, but at least less ugly. 😉

And some box-shadow for individual items:

.view-showcase .views-row {
  background: #fff;
  box-shadow: 0 0 12px #0003;
}

@olafgrabienski
Copy link

Friendly reminder: that page is broken for several months now

Oh yes, the Showcases view is really a shame. Who can implement suggestions?

@findlabnet
Copy link

Why NOT use Backdrop CMS? - answered that page. :-(

@indigoxela
Copy link
Contributor

indigoxela commented Jan 4, 2022

I can't implement it, but suggest. 😉 Another one, more masonry-style, as not all items are forced to same height:

.view-showcase .views-row {
  background: #ffffff;
  box-shadow: 0 0 15px #00000033;
  margin-bottom: 4rem;
  break-inside: avoid;
}
@media (min-width: 48em) {
  .view-showcase .view-content {
    column-count: 2;
    column-gap: 4rem;
  }
}

Changes to the view aren't necessary, but please adapt the showcase_preview image style to not be smaller than the views-row, because that makes the images so blurry. Currently it's 512x512, but even if we use columns like suggested, they still should be at least 546px wide.

column-style

@ghost
Copy link

ghost commented Jan 6, 2022

The Showcase page layout/styling has already been fixed: backdrop-contrib/borg#28 We're just waiting on a new release of the Borg theme to install on B.org (ping @jenlampton).

Here's what the page will look like once the theme's updated to the latest version:

Screen Shot 2022-01-06 at 12 07 58-fullpage

@jenlampton
Copy link
Member

I've applied the patch, committed the fix, and pushed up to backdropcms.org:
https://backdropcms.org/showcase

@docwilmot
Copy link
Contributor Author

Was this meant to have fixed the indistinctness? I dont see significant difference?

@docwilmot
Copy link
Contributor Author

Looking at the commit, the answer is no; it fixed the broken columns but didnt actually deal with this issue's complaint.

@docwilmot docwilmot reopened this Jan 6, 2022
@ghost
Copy link

ghost commented Jan 6, 2022

I was wondering the same thing. This issue got sidetracked and should really be about styling the Showcase items to stand out better.

@jenlampton
Copy link
Member

Ah, sorry folks. I thought that fix was what was wanted here. Jumped the gun on closing the issue -- thanks for catching it @docwilmot and @BWPanda.

@indigoxela
Copy link
Contributor

Another remaining task: update the image style to match the column width - to prevent the blurry look. Do we have an issue for that already?

@ghost
Copy link

ghost commented Jan 7, 2022

@indigoxela When I look at the page, the images used are 512px wide, and the columns they're now in are 548px wide... Is that really enough of a difference to worry about?

@indigoxela
Copy link
Contributor

Is that really enough of a difference to worry about?

It may depend on the person looking at it. 😉 For me this looks like "blurry bullshit", but maybe I'm a little picky re visual glitches.

@olafgrabienski
Copy link

The pictures look a bit blurry to me at well. (And being so small, they look very blurry on displays of higher pixel density.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants