Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Smart Menus version #5961

Open
laryn opened this issue Feb 6, 2023 · 3 comments
Open

Update Smart Menus version #5961

laryn opened this issue Feb 6, 2023 · 3 comments

Comments

@laryn
Copy link
Contributor

laryn commented Feb 6, 2023

Description of the need

I was searching for something related to Smart Menus and noticed that there have been tags since the version that is included in Backdrop core. We ship with 1.1.0 and there is a 1.1.1 version as well as a 1.2.1 since then.

https://github.com/vadikom/smartmenus/tags

We should assess whether and which to update to.

@klonos
Copy link
Member

klonos commented Feb 7, 2023

Collating the list of changes in the various versions, to help us figure out if there's been any breaking change:

1.1.1 (compare commits from 1.1.0)

  • Update demos with Bootstrap 4.5.0
  • fix: Mouse input not detected correctly on Windows when pointer speed is set to any of the fastest 2 options and additionally "Enhance pointer precision" is unchecked
  • fix: Avoid Content Security Policy issue when valid JSON is used as "data-sm-options" value Avoiding Content Security Policy issue? vadikom/smartmenus#88
  • fix: "showOnClick: true" should not affect collapsible mode behavior in any way
  • fix: Remove SHJS syntax highlighter source code from the repo
  • fix: Problem with markCurrentTree in megamenu Problem with markCurrentTree in megamenu vadikom/smartmenus#86
  • fix: Uncaught TypeError when clicking on items (that do not have a sub menu in certain cases) in collapsible mode

1.2.0 (compare commits from 1.1.1)

  • Support only valid JSON format for the value of the "data-sm-options" attribute and do not use eval() to parse it.

1.2.1 (compare commits from 1.2.0)

  • Bump Bootstrap 4 Addon version

@laryn
Copy link
Contributor Author

laryn commented Oct 3, 2023

I understand that there is a Smart Menus v2 coming out at some point (soon?):

@laryn
Copy link
Contributor Author

laryn commented Apr 29, 2024

In the meantime v2.0.0-alpha.1 has been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants