Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Repository: Renovate changesets on devDependencies #942

Open
2 tasks done
awanlin opened this issue Aug 23, 2024 · 3 comments · May be fixed by backstage/actions#159
Open
2 tasks done

🔧 Repository: Renovate changesets on devDependencies #942

awanlin opened this issue Aug 23, 2024 · 3 comments · May be fixed by backstage/actions#159
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@awanlin
Copy link
Contributor

awanlin commented Aug 23, 2024

📜 Description

The renovate-changeset action is adding changesets for changes that are only devDependencies. When we merge these changes it then kicks off the version packages which we don't need in this case as the package hans't actually changed

This is properly not something that we fix in this repo but here: https://github.com/backstage/actions/tree/main/renovate-changesets, logging it here for visibility and so I don't forget about it.

👍 Expected behavior

There should be not changesets if the changes are just related to devDependencies

👎 Current Behavior

Changesets are added when there change is just for devDependencies

👟 Reproduction steps

Example PR here: #877

📃 Provide the context for the Bug.

I merged this PR - #877 - which then triggers a bunch of Version Packages PRs.

👀 Have you spent some time to check if this bug has been raised before?

  • I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

Are you willing to submit PR?

No, but I'm happy to collaborate on a PR with someone else

@awanlin awanlin added the bug Something isn't working label Aug 23, 2024
@BethGriggs BethGriggs added the help wanted Extra attention is needed label Aug 30, 2024
@04kash
Copy link
Contributor

04kash commented Aug 30, 2024

I'd like to take a look at this, can I be assigned to the issue?

@BethGriggs
Copy link
Collaborator

Hey @04kash, thanks - assigned

@04kash
Copy link
Contributor

04kash commented Oct 9, 2024

Opened a PR for this issue here: backstage/actions#159

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants