Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shell script mistakes in sandbox #897

Open
lpstudy opened this issue Jun 1, 2017 · 0 comments
Open

shell script mistakes in sandbox #897

lpstudy opened this issue Jun 1, 2017 · 0 comments

Comments

@lpstudy
Copy link

lpstudy commented Jun 1, 2017

I found some minor mistakes of shell scripts in sandbox directory.

  1. "$1"x == "master_slave" extra x is missed in master_slave
  2. when adopting raft mode, sleep 5 seconds is not enough for the system to run. I encounted bfs_client put error when deploying raft mode by sleep 5-10 seconds.
  3. I think it is not good to show process not found when running clear.sh. Killing the process should work without any error message. For the new guy like me to run deploy.sh and get the message process not found, I think there is something wrong with the deploy.sh. However, it works OK.
  4. cd - will print current work directory when using start_bfs.sh. I also think this log is unnecessary. It doesn't give any useful information about the system. But the logs like nameserver 0 started ok at port xxx, chunkserver 0 started ok at port xxx should be added into the script, to make it more clear.
lpstudy added a commit to lpstudy/bfs that referenced this issue Jun 1, 2017
@lpstudy
Minor bug fix for shell scripts in sandbox directory
ff898a4 
(baidu#897)
deploy.sh:    extra x in "$1"x == "master_slave". Also add `-h` option which is common in linux shell scripts.
start_bfs.sh: bfs can not work well with raft mode enabled with only sleeping 5 seconds, add 'sleep 30' when using raft mode.
clear.sh:     redirect the error log message like `process not found` to `/dev/null`. It does no good but confuses the users.
start_bfs.sh: `cd -` print the working directory which is useless. Add the server starting message like `start nameserver0 with pid xxx`
@lpstudy lpstudy mentioned this issue Jun 1, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lpstudy