Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor fetching of renderable fields #40

Open
ondrowan opened this issue Aug 13, 2012 · 1 comment
Open

Refactor fetching of renderable fields #40

ondrowan opened this issue Aug 13, 2012 · 1 comment
Milestone

Comments

@ondrowan
Copy link
Contributor

Right now it's scattered on two places:

  • in findOrderedPollFields in Entity/FieldManager. This one should handle only ordering anyway.
  • in buildForm in PollType - but only for child fields.

It should be extracted to one and only one place where it'll be handled.

ondrowan added a commit that referenced this issue Aug 14, 2012
Rewritten query for fetching poll fields and renamed it to
findRenderableOrderedFields. #40
@ondrowan
Copy link
Contributor Author

Method isRenderable in field model became redundant with previous commit. We should remove it if we won't use it in near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant