Skip to content

Commit bc347f9

Browse files
authored
Merge pull request #692 from balancer/review/issue-691
Review: Rate Provider from Issue #691
2 parents 6b770f7 + d10b565 commit bc347f9

4 files changed

Lines changed: 73 additions & 1 deletion

File tree

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
1+
2+
# Rate Provider: SavingsVaultZCHF rate provider
3+
4+
## Details
5+
This report was autogenerated on 12/03/2026.
6+
7+
- Deployed at:
8+
- [Ethereum:0xe5f130253ff137f9917c0107659a4c5262abf6b0](https://etherscan.io/address/0xe5f130253ff137f9917c0107659a4c5262abf6b0)
9+
- Audit report(s):
10+
- [Audits](https://code4rena.com/reports/2023-04-frankencoin)
11+
12+
## Context
13+
https://docs.frankencoin.com/
14+
15+
## Review Checklist: Bare Minimum Compatibility
16+
Each of the items below represents an absolute requirement for the Rate Provider. If any of these is unchecked, the Rate Provider is unfit to use.
17+
18+
- [x] Tests based on the [balancer-v3-monorepo](https://github.com/balancer/balancer-v3-monorepo/tree/main/pkg/vault/test/foundry/fork) pass for the given ERC4626 vaults, which can be found [here](https://github.com/balancer/balancer-v3-erc4626-tests/tree/main/test).
19+
- [x] The required Vault implements the required operational ERC4626 Interface
20+
21+
### Administrative Privileges
22+
- [ ] The ERC4626 Vault is upgradeable** (e.g., via a proxy architecture).
23+
- [ ] Other contracts which are part of the `mint` callchain are upgradeable**. You can find more information
24+
about the involved contracts in this [tenderly simulation](https://www.tdly.co/shared/simulation/a58226cb-6b7d-4603-af83-e515916d48db)
25+
26+
## Conclusion
27+
**Summary judgment: USABLE**
28+
Passing fork tests can be found at balancer/balancer-v3-erc4626-tests#120.
29+
30+
** upgradeable in this context means that:
31+
- The contract is a proxy contract with an implementation sourced from Etherscan.
32+

erc4626/registry.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -781,7 +781,7 @@
781781
"asset": "0xB58E61C3098d85632Df34EecfB899A1Ed80921cB",
782782
"name": "SavingsVaultZCHFErc4626Vault.md",
783783
"summary": "safe",
784-
"review": "./SavingsVaultZCHFErc4626VaultReviewa38f.md",
784+
"review": "./SavingsVaultZCHFErc4626VaultReviewba56.md",
785785
"warnings": [],
786786
"upgradeableComponents": [],
787787
"canUseBufferForSwaps": true,
Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
1+
2+
# Rate Provider: SavingsVaultZCHF rate provider
3+
4+
## Details
5+
This report was autogenerated on 12/03/2026.
6+
7+
- Deployed at:
8+
- [Ethereum:0xf32dc0eE2cC78Dca2160bb4A9B614108F28B176c](https://etherscan.io/address/0xf32dc0eE2cC78Dca2160bb4A9B614108F28B176c)
9+
- Audit report(s):
10+
- [Audits](https://code4rena.com/reports/2023-04-frankencoin)
11+
12+
## Context
13+
https://docs.frankencoin.com/
14+
15+
## Review Checklist: Bare Minimum Compatibility
16+
Each of the items below represents an absolute requirement for the Rate Provider. If any of these is unchecked, the Rate Provider is unfit to use.
17+
18+
- [x] Implements the [`IRateProvider`](https://github.com/balancer/balancer-v2-monorepo/blob/bc3b3fee6e13e01d2efe610ed8118fdb74dfc1f2/pkg/interfaces/contracts/pool-utils/IRateProvider.sol) interface.
19+
- [x] `getRate` returns an 18-decimal fixed point number (i.e., 1 == 1e18) regardless of underlying token decimals.
20+
21+
### Administrative Privileges
22+
- [ ] The Rate Provider is upgradeable** (e.g., via a proxy architecture).
23+
- [ ] Other contracts which are part of the `getRate` callchain are upgradeable**. You can find more information
24+
about the involved contracts in this [tenderly simulation](https://www.tdly.co/shared/simulation/bf04e0d5-1a67-4bd5-b10a-7b6e24f4b461)
25+
26+
## Conclusion
27+
**Summary judgment: USABLE**
28+
29+
** upgradeable in this context means that:
30+
- The contract is a proxy contract with an implementation sourced from Etherscan and the proxy emitted an "Upgraded" event.
31+

rate-providers/registry.json

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3816,6 +3816,15 @@
38163816
"implementationReviewed": "0x4e7991e5c547ce825bdeb665ee14a3274f9f61e0"
38173817
}
38183818
]
3819+
},
3820+
"0xf32dc0eE2cC78Dca2160bb4A9B614108F28B176c": {
3821+
"asset": "0xe5f130253ff137f9917c0107659a4c5262abf6b0",
3822+
"name": "SavingsVaultZCHFRateProvider.md",
3823+
"summary": "safe",
3824+
"review": "./SavingsVaultZCHFRateProviderReview6db3.md",
3825+
"warnings": [],
3826+
"factory": "",
3827+
"upgradeableComponents": []
38193828
}
38203829
},
38213830
"fantom": {

0 commit comments

Comments
 (0)