Upgrade to Batch SDK 1.12 + GCM -> FCM migration (#11)

* Take into account root project config

* Upgrade Batch SDK

* Remove GCM things

* Add paragraph on small push notification icon

* Remove unneeded permissions in AndroidManifest

* Fix for older build tools

Author: Minishlink

README.md

@@ -34,19 +34,40 @@ pod install
 
 #### Android
 
-Go to the Batch dashboard, create an Android app and setup your GCM configuration.
+Go to the Batch dashboard, create an Android app and setup your FCM configuration.
+Make sure to have added Firebase Messaging as stated in the [Batch documentation](https://batch.com/doc/android/sdk-integration.html#_adding-push-notifications-support).
 Then, in `android/app/build.gradle`, provide in your config:
 
 ```
 defaultConfig {
     ...
-    resValue "string", "GCM_SENDER_ID", "%YOUR_GCM_SENDER_ID%"
     resValue "string", "BATCH_API_KEY", "%YOUR_BATCH_API_KEY%"
 }
 ```
 
 Note that you can also customize the keys depending on your product flavor or build type.
 
+#### Small push notification icon
+
+It is recommended to provide a small notification icon in your `MainActivity.java`:
+
+```java
+// push_icon.png in your res/drawable-{dpi} folder
+import com.batch.android.Batch;
+import android.os.Bundle;
+import android.graphics.Color;
+
+...
+
+    @Override
+    protected void onCreate(Bundle savedInstanceState) {
+        super.onCreate(savedInstanceState);
+
+        Batch.Push.setSmallIconResourceId(R.drawable.push_icon);
+        Batch.Push.setNotificationsColor(Color.parseColor(getResources().getString(R.color.pushIconBackground)));
+    }
+```
+
 ##### Mobile landings and in-app messaging
 
 If you set a custom `launchMode` in your `AndroidManifest.xml`, add in your `MainActivity.java`:

android/build.gradle

@@ -1,3 +1,7 @@
+def DEFAULT_COMPILE_SDK_VERSION             = 25
+def DEFAULT_BUILD_TOOLS_VERSION             = "25.0.2"
+def DEFAULT_TARGET_SDK_VERSION              = 22
+
 buildscript {
     repositories {
         jcenter()
@@ -11,12 +15,12 @@ buildscript {
 apply plugin: 'com.android.library'
 
 android {
-    compileSdkVersion 25
-    buildToolsVersion "25.0.2"
+    compileSdkVersion rootProject.hasProperty('compileSdkVersion') ? rootProject.compileSdkVersion : DEFAULT_COMPILE_SDK_VERSION
+    buildToolsVersion rootProject.hasProperty('buildToolsVersion') ? rootProject.buildToolsVersion : DEFAULT_BUILD_TOOLS_VERSION
 
     defaultConfig {
         minSdkVersion 16
-        targetSdkVersion 22
+        targetSdkVersion rootProject.hasProperty('targetSdkVersion') ? rootProject.targetSdkVersion : DEFAULT_TARGET_SDK_VERSION
         versionCode 1
         versionName "1.0"
     }
@@ -34,7 +38,5 @@ repositories {
 
 dependencies {
     compile 'com.facebook.react:react-native:+'
-    compile "com.batch.android:batch-sdk:1.10.2+"
-    compile "com.google.android.gms:play-services-base:+"
-    compile 'com.google.android.gms:play-services-gcm:+'
+    compile "com.batch.android:batch-sdk:1.12.0+"
 }

android/src/main/AndroidManifest.xml

@@ -1,26 +1,3 @@
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
           package="tech.bam.RNBatchPush">
-
-    <uses-permission android:name="android.permission.INTERNET" />
-    <uses-permission android:name="android.permission.WAKE_LOCK" />
-    <uses-permission android:name="android.permission.VIBRATE" />
-    <permission android:name="${applicationId}.permission.C2D_MESSAGE" android:protectionLevel="signature"/>
-    <uses-permission android:name="${applicationId}.permission.C2D_MESSAGE"/>
-    <uses-permission android:name="com.google.android.c2dm.permission.RECEIVE"/>
-
-    <application>
-        <service android:name="com.batch.android.BatchPushService" />
-        <receiver android:name="com.batch.android.BatchPushReceiver" android:permission="com.google.android.c2dm.permission.SEND">
-            <intent-filter>
-                <action android:name="com.google.android.c2dm.intent.RECEIVE" />
-                <category android:name="${applicationId}" />
-            </intent-filter>
-        </receiver>
-
-        <service android:name="com.batch.android.BatchPushInstanceIDService" android:exported="true">
-            <intent-filter>
-                <action android:name="com.google.android.gms.iid.InstanceID"/>
-            </intent-filter>
-        </service>
-    </application>
 </manifest>

android/src/main/java/tech/bam/RNBatchPush/RNBatchPushModule.java

@@ -38,8 +38,6 @@ public RNBatchPushModule(ReactApplicationContext reactContext) {
       Resources resources = reactContext.getResources();
       String packageName = reactContext.getApplicationContext().getPackageName();
       this.batchAPIKey = resources.getString(resources.getIdentifier("BATCH_API_KEY", "string", packageName));
-
-      Batch.Push.setGCMSenderId(resources.getString(resources.getIdentifier("GCM_SENDER_ID", "string", packageName)));
       Batch.setConfig(new Config(this.batchAPIKey));
 
       startBatch();