Merge pull request #38 from jr-k/patch-1

Nhacsam · web-flow · commit 1b805fb9f59e · 2018-03-21T18:57:08.000+01:00
Important ! Listener is not removed
diff --git a/src/TriggeringView.js b/src/TriggeringView.js
@@ -74,7 +74,7 @@ class TriggeringView extends Component<Props, State> {
       return;
     }
     this.context.scrollY.removeListener(this.listenerId);
-    nextContext.scrollY.addListener(this.onScroll);
+    this.listenerId = nextContext.scrollY.addListener(this.onScroll);
   }
 
   onRef = (ref: any) => {

Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,7 @@ class TriggeringView extends Component<Props, State> {`
`74`	`74`	`return;`
`75`	`75`	`}`
`76`	`76`	`this.context.scrollY.removeListener(this.listenerId);`
`77`		`- nextContext.scrollY.addListener(this.onScroll);`
	`77`	`+ this.listenerId = nextContext.scrollY.addListener(this.onScroll);`
`78`	`78`	`}`
`79`	`79`
`80`	`80`	`onRef = (ref: any) => {`