Add option to hide background colors #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cretezy
approved these changes
May 2, 2021
|
Nice! Thanks for working on this. I have a slightly different approach in mind so I'm going to take a stab at that first instead, hope you don't mind. |
|
No worries, it's your project! Feel free to reopen and use this down the line if it ever becomes useful. |
|
It's great, I'm looking for a theme like this. |
|
would like to see something like this |
|
That'd really be great 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a config option called hide-background which, when enabled, will render the following colors with transparent backgrounds:
The result (using
github-dark-dim):It's somewhat debatable whether HUNK_HEADER_COLOR should be included as well
Closes #7