Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: YAML parse error when using wildcard CA namespace #102

Closed
wants to merge 4 commits into from
Closed

fix: YAML parse error when using wildcard CA namespace #102

wants to merge 4 commits into from

Conversation

csatib02
Copy link
Member

@csatib02 csatib02 commented Feb 8, 2024 •
edited
Loading

Overview

  • Added a check in secret.yaml, to check for the "*" wildcard.

Fixes #76

@csatib02
fix: #76
7fe84bf 
Signed-off-by: Bence Csati <[email protected]>
@csatib02 csatib02 requested a review from a team as a code owner February 8, 2024 15:36
@csatib02 csatib02 requested review from sagikazarmark and removed request for a team February 8, 2024 15:36
@github-actions github-actions bot added the size/M Denotes a PR that changes 100-499 lines label Feb 8, 2024
@csatib02
fix: minor fixes
11ebd70 
Signed-off-by: Bence Csati <[email protected]>
@csatib02
chore: comments
a6445d3 
Signed-off-by: Bence Csati <[email protected]>
@csatib02 csatib02 marked this pull request as draft February 9, 2024 12:17
@csatib02
revert
c2b916d 
Signed-off-by: Bence Csati <[email protected]>
@github-actions github-actions bot added size/S Denotes a PR that changes 10-99 lines and removed size/M Denotes a PR that changes 100-499 lines labels Feb 9, 2024
@ramizpolic ramizpolic changed the title fix: YAML Parse error fix: YAML parse error when using wildcard CA namespace Feb 9, 2024
@csatib02 csatib02 closed this Mar 14, 2024
@csatib02 csatib02 deleted the fix/yaml-parse-error branch March 14, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sagikazarmark sagikazarmark Awaiting requested review from sagikazarmark sagikazarmark is a code owner automatically assigned from bank-vaults/maintainers

Assignees
No one assigned
Labels
size/S Denotes a PR that changes 10-99 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

YAML Parse error when using caNamespaces: ["*"]
1 participant
@csatib02