Merge pull request #192 from bank-vaults/ci-update-versions

ci(GHA): updated Vault versions in test matrix
bank-vaults · Sep 8, 2023 · c47edb1 · c47edb1
2 parents aec659a + 605465b
commit c47edb1
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -211,7 +211,7 @@ jobs:
     strategy:
       matrix:
         k8s_version: ["v1.24.15", "v1.25.11", "v1.26.6", "v1.27.3"]
-        vault_version: ["1.11.12", "1.12.8", "1.13.4", "1.14.1"]
+        vault_version: ["1.11.12", "1.12.9", "1.13.5", "1.14.1"] # latest versions with MPL 2.0 license
 
     steps:
       - name: Checkout repository

diff --git a/pkg/apis/vault/v1alpha1/vault_types_test.go b/pkg/apis/vault/v1alpha1/vault_types_test.go
@@ -23,10 +23,10 @@ import (
 func TestGetVersion(t *testing.T) {
 	t.Run("Good", func(t *testing.T) {
 		tests := []string{
-			"hashicorp/vault:1.14.0",
-			"hashicorp/vault:1.14",
-			"my.local.proxy/hashicorp/vault:1.14.0",
-			"my.local.proxy:5000/hashicorp/vault:1.14.0",
+			"bank-vaults/my-vault:1.2.3",
+			"bank-vaults/my-vault:1.2",
+			"my.local.proxy/bank-vaults/my-vault:1.2.3",
+			"my.local.proxy:5000/bank-vaults/my-vault:1.2.3",
 		}
 
 		for _, tt := range tests {
@@ -45,9 +45,9 @@ func TestGetVersion(t *testing.T) {
 
 	t.Run("Bad", func(t *testing.T) {
 		tests := []string{
-			"hashicorp/vault",
-			"hashicorp/vault:latest",
-			"hashicorp/vault:my-custom-build",
+			"bank-vaults/my-vault",
+			"bank-vaults/my-vault:latest",
+			"bank-vaults/my-vault:my-custom-build",
 		}
 
 		for _, tt := range tests {