Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect Helm namespace #331

Closed
cjyar opened this issue Oct 24, 2022 · 4 comments
Closed

Respect Helm namespace #331

cjyar opened this issue Oct 24, 2022 · 4 comments

Comments

@cjyar
Copy link

cjyar commented Oct 24, 2022

Is your feature request related to a problem? Please describe.
Deploying the vault-operator Helm chart via Kustomize's helmCharts feature, all of the resources end up in the default namespace. It appears that the Helm chart doesn't specify a namespace on any of its resources.

Describe the solution you'd like
If I specify a namespace, I'd like vault-operator to deploy into that namespace.

Describe alternatives you've considered
I'm currently using 9 patchesJson6902 patches to move resources into the correct namespace.

Additional context
It looks like other Helm charts include this in every namespaced resource's metadata:

  namespace: {{ .Release.Namespace }}
Copy link

Thank you for your contribution! This issue has been automatically marked as stale because it has no recent activity in the last 60 days. It will be closed in 20 days, if no further activity occurs. If this issue is still relevant, please leave a comment to let us know, and the stale label will be automatically removed.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR that has become stale and will be auto-closed. label Dec 31, 2023
@akijakya akijakya transferred this issue from bank-vaults/bank-vaults Jan 9, 2024
@akijakya
Copy link
Member

akijakya commented Jan 9, 2024

This issue is tracked here now, sorry for the long delay!

@akijakya akijakya closed this as completed Jan 9, 2024
@rljohnsn
Copy link

I believe this was closed inadvertently.

@akijakya
Copy link
Member

I believe this was closed inadvertently.

Sorry, I fixed the link in my previous comment. The underlying issue here is the kustomize support, solving that would solve this issue as well, and that is why I closed it.

@csatib02 csatib02 removed the lifecycle/stale Denotes an issue or PR that has become stale and will be auto-closed. label May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants