Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add app.kubernetes.io/instance to selector.matchLabels #612

Open
2 tasks done
komasztania opened this issue Oct 10, 2024 · 0 comments
Open
2 tasks done

Add app.kubernetes.io/instance to selector.matchLabels #612

komasztania opened this issue Oct 10, 2024 · 0 comments
Labels
kind/enhancement Categorizes issue or PR as related to an improvement.

Comments

@komasztania
Copy link

Preflight Checklist

  • I have searched the issue tracker for an issue that matches the one I want to file, without success.
  • I agree to follow the Code of Conduct.

Problem Description

Could you add app.kubernetes.io/instance to selector.matchLabels ?

Proposed Solution

  selector:
    matchLabels:
      app.kubernetes.io/name: {{ include "vault-operator.name" . }}
      app.kubernetes.io/instance: {{ .Release.Name }}

Alternatives Considered

No response

Additional Information

reference: https://github.com/bank-vaults/vault-secrets-webhook/blob/295df329b7be7f6028f992501fc6629e421944c9/deploy/charts/vault-secrets-webhook/templates/webhook-deployment.yaml#L20

@komasztania komasztania added the kind/enhancement Categorizes issue or PR as related to an improvement. label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Categorizes issue or PR as related to an improvement.
Projects
None yet
Development

No branches or pull requests

1 participant