Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new examples #190

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Add new examples #190

merged 1 commit into from
Sep 7, 2023

Conversation

sagikazarmark
Copy link
Member

Overview

This PR is the first in a row.
It adds new examples that are easier to follow and test.

Notes for reviewer

Signed-off-by: Mark Sagi-Kazar <[email protected]>
Copy link
Member

@akijakya akijakya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! The goal here is to replace the examples in deploy/examples? If not, I think these two dirs should be put together somehow...

@sagikazarmark
Copy link
Member Author

Nice! The goal here is to replace the examples in deploy/examples? If not, I think these two dirs should be put together somehow...

It is...those "old" examples are largely without context, are not kept up-to-date and as a result most of them may not even work anymore.

@sagikazarmark sagikazarmark merged commit e6bde6e into main Sep 7, 2023
29 checks passed
@sagikazarmark sagikazarmark deleted the examples branch September 7, 2023 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants