Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change in Delta value fill color for contest predictions. #2

Closed
amitpant14 opened this issue Dec 25, 2022 · 3 comments
Closed

change in Delta value fill color for contest predictions. #2

amitpant14 opened this issue Dec 25, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@amitpant14
Copy link

Currently, when there is a positive change in rating, it is depicted in red color and is green on negative changes. I think it would be better to use green color to reflect positive changes and red for negative ones.

@baoliay2008
Copy link
Owner

Hi, @amitpant14 thank you for mentioning this.

Here are some cultural differences, usually red means up and green means down in some countries like China, Korea, Japan, etc. (like stocks, reference)

I'm working on a new version of building webpages using React, and the current pages will be deprecated. So I will try to set the fill color for different countries.

@amitpant14
Copy link
Author

@baoliay2008 I see. Thanks for clarifying. I didn't know about this.

@baoliay2008 baoliay2008 added the enhancement New feature or request label Feb 6, 2023
@baoliay2008 baoliay2008 self-assigned this Sep 2, 2023
@baoliay2008
Copy link
Owner

This feature has been successfully implemented. Now, we automatically detect the user's browser language preference and customize the color scheme based on regional configurations.

For instance, Chinese and Japanese users will experience a color scheme of up: 🟥, down: 🟩, while Korean users will see up: 🟥, down: 🟦. By default, users in other regions, such as North America, Europe, and India, will encounter up: 🟩, down: 🟥.

For details, please check 3404fad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants