Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add number of signals ("# Signals:") #343

Closed
Vascom opened this issue Sep 12, 2019 · 8 comments
Closed

Add number of signals ("# Signals:") #343

Vascom opened this issue Sep 12, 2019 · 8 comments

Comments

@Vascom
Copy link

Vascom commented Sep 12, 2019

Summary:

"# Sats:" field show wrong number of satellites on L1/L5 receivers.

Steps to reproduce:

Run app on L1/L5 receiver like Xiaomi Mi 9.

Expected behavior:

Show real number of satellites even if one satellite has two signals.

Observed behavior:

I see each signals as separate satellite.

Device and Android version:

Xiaomi mi 9. MIUI 10.2.8.

@barbeau
Copy link
Owner

barbeau commented Sep 12, 2019

@Vascom Good point! I'll work on fixing this. May have common implementation items with some of the features under #313.

@barbeau barbeau added this to the v3.3 milestone Sep 12, 2019
@barbeau barbeau modified the milestones: v3.3, v3.5 Sep 20, 2019
@barbeau
Copy link
Owner

barbeau commented Oct 23, 2019

I've started working on logic that can support this at #355.

@Vascom
Copy link
Author

Vascom commented Oct 23, 2019

Thanks.

Also it will be good if instead list second signal as new string you just show SNR of second signal in second column.

Like this:
Id GNSS CF1cn0 CF2cn0 flags Elev Azim

So many signals (about 60) hard to see on one screen, every time need to scroll it.

@barbeau
Copy link
Owner

barbeau commented Jan 23, 2020

I just merged #355, so the "# Sats" value will now be correct on dual-frequency devices. I'll leave this open for showing "# Signals" as well in the UI (somewhere).

@barbeau
Copy link
Owner

barbeau commented Jan 24, 2020

Number of satellites should now be correct for dual-frequency devices in the new beta release v3.5.3 - https://play.google.com/apps/testing/com.android.gpstest.

If you have a dual-frequency device please test and let me know if it looks right!

@Vascom
Copy link
Author

Vascom commented Jan 24, 2020

I tested on Xiaomi Mi 9.
Work good. Sats number as expected.

@barbeau
Copy link
Owner

barbeau commented Jan 24, 2020

Thanks @Vascom!

@barbeau barbeau removed the bug label Jan 24, 2020
@barbeau barbeau changed the title Split "# Sats:" field to real #sats and #signals Add number of signals ("# Signals:") Jan 24, 2020
@barbeau barbeau modified the milestones: v3.5, v3.7 Jun 23, 2020
@barbeau barbeau modified the milestones: v3.7, v3.9 Dec 10, 2020
@stale
Copy link

stale bot commented Jun 3, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 3, 2021
@Vascom Vascom closed this as completed Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants