Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turn: check fd deref cleanup on turn worker thread #8

Open
wants to merge 11 commits into
base: turn_thread
Choose a base branch
from

Conversation

jobo-zt
Copy link

@jobo-zt jobo-zt commented Oct 18, 2024

No description provided.

modules/turn/turn.c Outdated Show resolved Hide resolved
@jobo-zt
Copy link
Author

jobo-zt commented Oct 19, 2024

Discovered during testing。

thread 1
thrd_t *thrd= thrd_current();

thread 2
thrd_equal(thrd, thrd_current());

GetThreadId(thrd_current()) return ok. but GetThreadId(thrd) return err. thrd in thread 1
so fun thrd_equal return err.

I wrote a test program, but the problem doesn't always occur.

@jobo-zt
Copy link
Author

jobo-zt commented Oct 19, 2024

  1. we may need to use the function get_thread_id() in trace.c instead.
  2. we need to confirm whether thrd_equal will affect the re module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants