Skip to content

Conversation

@danyalprout
Copy link
Collaborator

Description

WIP PR to create a load tester (gobrr) and integrate it with basectl.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Feb 7, 2026

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@danyalprout danyalprout force-pushed the danyal/p2p-tester branch 6 times, most recently from 0df49d5 to cdf33e6 Compare February 9, 2026 16:53
danyalprout and others added 3 commits February 10, 2026 12:11
After shutdown, the replenisher stops adding permits but signers are
blocked forever in acquire_rate_permit().await. Call limiter.close() so
pending acquire_owned() calls return AcquireError, which the signer
already handles gracefully by breaking out of its loop.

Without this, all signers with target_tps configured deadlock on
shutdown, waiting for permits that will never come.
fix(gobrr): close rate limiter semaphore on shutdown
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants