You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The string_of_remote can't pattern match on just a string, it was expecting {cluster_by_addr, {IP, Host}} or {cluster_by_name, ClusterName}, which is the contents of state.remote.
I could do a PR with this change but it would be untested since I don't know how to make and test a build (new to Basho and working on Riak Explorer at the moment).
The text was updated successfully, but these errors were encountered:
Basho-JIRA
changed the title
waiting_for_cluster_members synchronous function should return state.remote instead of state.name
waiting_for_cluster_members synchronous function should return state.remote instead of state.name [JIRA: RIAK-2270]
Nov 6, 2015
Specifically, this line:
https://github.com/basho/riak_repl/blob/develop/src/riak_core_cluster_conn.erl#L309
which is:
I believe it should be:
If it were to follow the pattern of the reply from other states, like this:
https://github.com/basho/riak_repl/blob/develop/src/riak_core_cluster_conn.erl#L172
https://github.com/basho/riak_repl/blob/develop/src/riak_core_cluster_conn.erl#L227
https://github.com/basho/riak_repl/blob/develop/src/riak_core_cluster_conn.erl#L245
The error shows up when riak-repl displays the connections:
https://github.com/basho/riak_repl/blob/develop/src/riak_repl_console.erl#L303
The
string_of_remote
can't pattern match on just a string, it was expecting{cluster_by_addr, {IP, Host}}
or{cluster_by_name, ClusterName}
, which is the contents of state.remote.I could do a PR with this change but it would be untested since I don't know how to make and test a build (new to Basho and working on Riak Explorer at the moment).
The text was updated successfully, but these errors were encountered: