Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

waiting_for_cluster_members synchronous function should return state.remote instead of state.name [JIRA: RIAK-2270] #719

Open
travisbhartwell opened this issue Nov 6, 2015 · 0 comments

Comments

@travisbhartwell
Copy link

Specifically, this line:

https://github.com/basho/riak_repl/blob/develop/src/riak_core_cluster_conn.erl#L309

which is:

    {reply, {waiting_for_cluster_members, State#state.name}, waiting_for_cluster_members, State};

I believe it should be:

    {reply, {waiting_for_cluster_members, State#state.remote}, waiting_for_cluster_members, State};

If it were to follow the pattern of the reply from other states, like this:
https://github.com/basho/riak_repl/blob/develop/src/riak_core_cluster_conn.erl#L172
https://github.com/basho/riak_repl/blob/develop/src/riak_core_cluster_conn.erl#L227
https://github.com/basho/riak_repl/blob/develop/src/riak_core_cluster_conn.erl#L245

The error shows up when riak-repl displays the connections:
https://github.com/basho/riak_repl/blob/develop/src/riak_repl_console.erl#L303

The string_of_remote can't pattern match on just a string, it was expecting {cluster_by_addr, {IP, Host}} or {cluster_by_name, ClusterName}, which is the contents of state.remote.

I could do a PR with this change but it would be untested since I don't know how to make and test a build (new to Basho and working on Riak Explorer at the moment).

@Basho-JIRA Basho-JIRA changed the title waiting_for_cluster_members synchronous function should return state.remote instead of state.name waiting_for_cluster_members synchronous function should return state.remote instead of state.name [JIRA: RIAK-2270] Nov 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants