Merge pull request #76 from bastibe/repr

OK, I'm merging this.

> I don't see why we need `format` should require `subtype` and `endian`, but if you insist on it, we'll do it that way. I'd rather have always too much information than a different amount of information for different files.

If we get annoyed by the large amount of information, we can still remove the `format`/`subtype`/`endian` triple at a later point.

Also, let's see if the implementation of #58 sheds a different light on this.

Author: mgeier

pysoundfile.py

@@ -638,10 +638,10 @@ def __init__(self, file, mode='r', samplerate=None, channels=None,
             mode_int = _snd.SFM_WRITE
 
         old_fmt = format
-        self._name = getattr(file, 'name', file)
+        self._name = file
         if format is None:
-            format = str(self.name).rsplit('.', 1)[-1].upper()
-            if format not in _formats and 'r' not in modes:
+            format = str(getattr(file, 'name', file)).rsplit('.', 1)[-1]
+            if format.upper() not in _formats and 'r' not in modes:
                 raise TypeError(
                     "No format specified and unable to get format from "
                     "file extension: %s" % repr(self.name))
@@ -720,9 +720,10 @@ def __init__(self, file, mode='r', samplerate=None, channels=None,
     _file = None
 
     def __repr__(self):
-        return ('SoundFile("{}", mode="{}", samplerate={}, channels={}, '
-                'format="{}")').format(self.name, self.mode, self.samplerate,
-                                     self.channels, self.format)
+        return ('SoundFile(%r, mode=%r, samplerate=%i, channels=%i, '
+                'format=%r, subtype=%r, endian=%r)' %
+                (self.name, self.mode, self.samplerate, self.channels,
+                 self.format, self.subtype, self.endian))
 
     def __del__(self):
         self.close()

tests/test_pysoundfile.py

@@ -455,7 +455,8 @@ def test__repr__(sf_stereo_r):
     if not isinstance(sf_stereo_r.name, int):
         assert repr(sf_stereo_r) == ('SoundFile("{}", mode="r", '
                                      'samplerate=44100, channels=2, '
-                                     'format="WAV")').format(filename_stereo)
+                                     'format="WAV", subtype="FLOAT", '
+                                     'endian="FILE")').format(filename_stereo)
 
 def test_mode_should_be_in_write_mode(sf_stereo_w):
     assert sf_stereo_w.mode == 'w'