Add stat, lstat, fstat, chown and fchown that return and expect uid and gid as SIDs on Windows #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add native methods getown and fgetown getting a file ownership and chown and fchown changing a file ownership. Add the exposed methods to the JavaScript file-ext.js. Add tests for stat and chown methods.
|
I'm so sorry I've been so delinquent in replying to this PR. It might make sense to merge this, but I think it might now be incorrect as we've ported the core to use nan so that things will build on both 0.10 and below, and 0.11 and above. Would it be possible to bring this PR up to date? |
This was referenced Jun 3, 2015
|
Can you bring this up to date? We have windows testing now on appveyor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This belongs to the issue #26.