Fix multiple-definition error on windows_config_setting (#1084)

bazel-contrib · Aug 25, 2023 · 7b67354 · 7b67354
1 parent 816905a
commit 7b67354
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/foreign_cc/utils.bzl b/foreign_cc/utils.bzl
@@ -22,9 +22,11 @@ def runnable_binary(name, binary, foreign_cc_target, match_binary_name = False,
 
     tags = kwargs.pop("tags", [])
 
+    config_setting_name = name + "_windows_config_setting"
+
     # filegroups cannot select on constraint_values in before Bazel 5.1. Add this config_setting as a workaround. See https://github.com/bazelbuild/bazel/issues/13047
     native.config_setting(
-        name = "windows_config_setting",
+        name = config_setting_name,
         constraint_values = [
             "@platforms//os:windows",
         ],
@@ -35,7 +37,7 @@ def runnable_binary(name, binary, foreign_cc_target, match_binary_name = False,
         srcs = [foreign_cc_target],
         tags = tags + ["manual"],
         output_group = select({
-            ":windows_config_setting": binary + ".exe",
+            ":" + config_setting_name: binary + ".exe",
             "//conditions:default": binary,
         }),
     )