Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Buildifier cannot find .buildifier-tables.json when run from a subdirectory #1312

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Fix: Buildifier cannot find .buildifier-tables.json when run from a subdirectory #1312

wants to merge 6 commits into from
+127 −4

Conversation

dpleshakov
Copy link

@dpleshakov dpleshakov commented Dec 1, 2024 •
edited
Loading

Fix the issue where Buildifier fails to locate the .buildifier-tables.json file when specifying a relative path in the AddTables configuration and running Buildifier from subdirectories within the workspace. Adding the findTablesPath function similar to the FindConfigPath to search for .buildifier-tables.json.

Fix #1311

@dpleshakov
Fix: Resolve Relative Path Issues for .buildifier-tables.json in AddT…
bb62d34 
…ables Configuration

This commit addresses an issue where Buildifier fails to locate the .buildifier-tables.json file when specifying a relative path in the AddTables configuration and running Buildifier from subdirectories within the workspace.
@dpleshakov dpleshakov marked this pull request as draft December 1, 2024 12:59
@dpleshakov
Copy link
Author

Does anyone know how to get tests logs from macOS into account the error below?

(14:11:43) INFO: Build Event Protocol files produced successfully.
buildkite-agent artifact upload --content_type=text/plain;encoding=utf-8 buildifier/config/config_test/test_attempts/attempt_1.log
Incorrect Usage: flag provided but not defined: -content_type```

@dpleshakov dpleshakov changed the title Fix issue: Buildifier cannot find .buildifier-tables.json when run from a subdirectory within the workspace. Fix: Buildifier cannot find .buildifier-tables.json when run from a subdirectory Dec 3, 2024
@dpleshakov
Copy link
Author

dpleshakov commented Dec 3, 2024 •
edited
Loading

Does anyone know how to get tests logs from macOS into account the error below?

(14:11:43) INFO: Build Event Protocol files produced successfully.
buildkite-agent artifact upload --content_type=text/plain;encoding=utf-8 buildifier/config/config_test/test_attempts/attempt_1.log
Incorrect Usage: flag provided but not defined: -content_type```

Ok ,the issue was related to the bazelbuild/continuous-integration release versions 0.2.3 or 0.2.4. There is no error with version 0.2.5 after ff92ddf17592e330b64cfc4fad132eb91190de00. The log of the failed test is successfully attached.

@dpleshakov dpleshakov marked this pull request as ready for review December 3, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladmos vladmos Awaiting requested review from vladmos vladmos is a code owner

@pmbethe09 pmbethe09 Awaiting requested review from pmbethe09 pmbethe09 is a code owner

@larsrc-google larsrc-google Awaiting requested review from larsrc-google larsrc-google is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Buildifier cannot find .buildifier-tables.json when run from a subdirectory within the workspace.
1 participant
@dpleshakov